This repository has been archived by the owner on May 15, 2023. It is now read-only.
Pull Request(Backend): Migrate to Typescript #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ming-suhi
commented
Dec 6, 2021
ming-suhi
commented
- Converted JS files to TS
- Refactored structures;
- Added tests
- Added types
- Converted some methods to functions
- Changed names
- Changed directories and architecture
- Fixed undetected bug found with tests
- Installed necessary dependencies - Added tsconfig
- Converted message file to typescript - Refactored classes, removed methods and made it into separate functions for easy testing and organization - Created necessary types - Added documentation
- Created rawMessage, rawParticipant, and rawChannel
- Removed wordCountObject and replaced it with countObject for more general use - Added a mergeCountObjectArrays function to merge two arrays of count objects - Refactored message file in line with new changes
- Converted file-system file to typescript - Refactored classes, removed methods and made it into separate functions for easy testing and organization
- Added build script - Made minor changes to tsconfig
- Removed wordOccurences from constructor, converted to getter - Message content property is now always string
- Files property only now gets files with .js and .json extension - rawMessage type property content, made optional
- Installed testing packages - Configure testing configs - Added tests for message and count - Deleted js file that have been converted to ts
- Moved functions from structures to services - Added more tests
- Converted all files to typescript - Moved client inside structures - Added client-consumer - Minor fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.