Adding support for config toml files to parse flags #12

Rachit1313 · 2023-10-05T03:35:06Z

I would be working on issue #11 through this PR.

Rachit1313 · 2023-10-05T03:55:43Z

Hi,
The implementation for the feature has been completed from my side.

Could you please review it and let me know if any changes are required?

Thank you.

README.md

txt2html.py

mingming-ma

All good and approved, will do the merge it manually by the lab Step6. Thanks

Rachit1313 added 6 commits October 4, 2023 23:34

imported tomli and added a parser argument for config

9a23f34

Added condition to check config file and overiding any other lang flag

c47cc31

Fixed the condition to open file with binary mode and fixed variables

f7f7318

added toml reading failed exception handling

ec3ff1d

updated version and documentation regarding config flag

79c5624

Fixed spacing in Config sample readme

39d70dc

Rachit1313 marked this pull request as ready for review October 5, 2023 03:54

mingming-ma requested changes Oct 5, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

txt2html.py Outdated Show resolved Hide resolved

txt2html.py Outdated Show resolved Hide resolved

mingming-ma reviewed Oct 5, 2023

View reviewed changes

txt2html.py Outdated Show resolved Hide resolved

Rachit1313 marked this pull request as draft October 5, 2023 17:32

Rachit1313 added 2 commits October 5, 2023 13:34

Fixed version in readme and exiting if any of exceptions triggered

d0060ae

Implemented output flag handling in toml config

938d2a4

Rachit1313 marked this pull request as ready for review October 5, 2023 17:38

Rachit1313 requested a review from mingming-ma October 5, 2023 17:38

mingming-ma reviewed Oct 5, 2023

View reviewed changes

mingming-ma merged commit 938d2a4 into mingming-ma:main Oct 5, 2023

Provide feedback