-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unwatch produces NaN for last position #5
Comments
I think the .js file is generated by coffee script. It would be better to search the "bug" in the .coffee file. In this case it might help to "compile" the .coffee file again with the current version. @mingqi will you maintain this repository and accept pull requests/publish to npm? |
I made some tests in my fork, and setting the option "bufferSize: -1", did not produce NaN. |
@megastef yes, I maintain this repository and accept PR to npm |
@mingqi Thank you very much for the quick merge! |
unwatch() doesn't seem to work very well. I don't nodejs very well, so having a difficult time understanding the async.reduce() call. Maybe a name clash with
start
? For anything but the first iteration,start
becomes undefined which causes this to go sideways.As long file is less than buffer size, seems ok...
but as soon as more than one chunk is read, the last known position goes NaN:
The text was updated successfully, but these errors were encountered: