-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the resource images size #176
Comments
There are many ways to reduce the overall footprint of the project (both the production artifact and the git repository).
|
One more idea copied from #764 :
|
@gabriel-tessier How would you handle air-gapped or offline networks? |
Quick observation: it appears that the As @bdsoha suggested above, we could copy the contents of https://github.com/mingrammer/diagrams/tree/master/resources to the docs folder at CI time in order to build the docs site, but otherwise have only a single copy of the I added this change in #748. The |
if you want to access the icon offline you can always git clone the repository in a local dir and follow the doc: |
@gabriel-tessier The documentation describes a use-case in which you want to include an icon not distributed with the packages. What you are suggesting would require the package consumer to import all the image resources to the air-gapped network and then overwrite the It would be better to include an option of |
I just ran a test using the
|
See #866 |
@Kochise Using |
@bdsoha Yeah, I know, but it helps. |
I update my comment above. |
It was your point 3 already, I just linked to the other issue to aggregate the requests. But indeed, SVG do help, like, by a lot. |
Corrected... 😁 |
autogen.sh
The text was updated successfully, but these errors were encountered: