URL, edgeURL, and labelURL support #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`edgeURL` and `labelURL` are technically already supported via the `**attrs` Dict in `Edge`'s initializer. I added a named parameter to `Node` to accept [`URL`](https://www.graphviz.org/doc/info/attrs.html#a:URL). SVG output natively supports links in the diagram. Links can also be added to jpg and png using `cmapx` which I added to the output types. To use cmapx you will need to run the diagram generation twice. Once for the png and once for the cmapx file. I had originally detected if a url was added to a node, edge, or label and autogenerated the cmapx file. I can add that back in if interested, but it seemed to break the paradigm of generating _one file_ from a diagram.
mingrammer
added
kind/feature
|
I think SVG native support would be enough. With cmapx, a user should create an HTML file containing the map filename and image filename. But it would be a bad experience in my thought as long as there are no ways to support link in PNG itself natively. |
|
I think there is a lot of value in just having the working SVG support. If others want PNG support that can perhaps be looked at in another PR - perfect is the enemy of shipped and all. |
|
is there anything preventing this from being rebased and merged? |
|
Keen to see this merged, will be great to combine with #508 which then allows one to click on containers / components & be taken to a git repo or similar for more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edgeURLandlabelURLare technically already supported via the**attrsDict inEdge's initializer.I added a named parameter to
Nodeto acceptURL.SVG output natively supports links in the diagram. Links can also be added to jpg and png using
cmapxwhich I added to the output types.To use cmapx you will need to run the diagram generation twice. Once for the png and once for the cmapx file.
I had originally detected if a url was added to a node, edge, or label and autogenerated the cmapx file. I can add that back in if interested, but it seemed to break the paradigm of generating one file from a diagram.
Closes #97