Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elastic stack (#134) #174

Merged
merged 2 commits into from
May 31, 2020
Merged

Add elastic stack (#134) #174

merged 2 commits into from
May 31, 2020

Conversation

gabriel-tessier
Copy link
Contributor

No description provided.

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM and SIEM should be uppercase. Please work for it :)

@gabriel-tessier
Copy link
Contributor Author

Thanks for the review I didn't pay attention to uppercase.
I fixed the 2 reported and add ECE and ECK as they display in uppercase on elastic.co website.

@mingrammer mingrammer added comp/node Issue of node component kind/feat/provider Provider request labels May 31, 2020
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you :)

@mingrammer mingrammer merged commit 1eed336 into mingrammer:master May 31, 2020
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...
@gabriel-tessier gabriel-tessier deleted the elastic_provider branch July 23, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/node Issue of node component kind/feat/provider Provider request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants