[iOS] Fixes text input plugin crash (flutter#20127)

mingwandroid · Jul 30, 2020 · f2b02d8 · f2b02d8
1 parent e9334c9
commit f2b02d8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm b/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm
@@ -387,8 +387,8 @@ - (void)dealloc {
 }
 
 - (UITextField*)textField {
-  if (_textField == nil) {
-    _textField = [[[UITextField alloc] init] autorelease];
+  if (!_textField) {
+    _textField = [[UITextField alloc] init];
   }
   return _textField;
 }

diff --git a/shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.m b/shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.m
@@ -17,6 +17,10 @@ - (void)setTextInputState:(NSDictionary*)state;
 - (BOOL)isVisibleToAutofill;
 @end
 
+@interface FlutterSecureTextInputView : FlutterTextInputView
+@property(nonatomic, strong) UITextField* textField;
+@end
+
 @interface FlutterTextInputPlugin ()
 @property(nonatomic, strong) FlutterTextInputView* reusableInputView;
 @property(nonatomic, assign) FlutterTextInputView* activeView;
@@ -496,4 +500,15 @@ - (void)testUITextInputCallsUpdateEditingStateOnce {
   [inputView unmarkText];
   XCTAssertEqual(updateCount, 6);
 }
+
+- (void)testNoZombies {
+  // Regression test for https://github.com/flutter/flutter/issues/62501.
+  FlutterSecureTextInputView* passwordView = [[FlutterSecureTextInputView alloc] init];
+
+  @autoreleasepool {
+    // Initialize the lazy textField.
+    [passwordView.textField description];
+  }
+  XCTAssert([[passwordView.textField description] containsString:@"TextField"]);
+}
 @end