Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the toolchain build instructions from mingw-builds to mingwpy's README.md #9

Closed
ogrisel opened this issue Mar 2, 2016 · 6 comments
Milestone

Comments

@ogrisel
Copy link
Contributor

ogrisel commented Mar 2, 2016

I think we should move the instructions from:

https://github.com/mingwpy/mingw-builds/blob/mingwpy-dev/mingwpy_readme.md

into the README.md of the main mingwpy repo.

This way we keep our mingwpy-dev branch of mingw-builds more inline with upstream and centralise the technical instructions to build the mingwpy toolchains in our own repo.

@ogrisel ogrisel added this to the Phase 1 milestone Mar 2, 2016
@techtonik
Copy link
Contributor

I thought that README is the main file. Now it looks like entrypoint is different.

@ogrisel
Copy link
Contributor Author

ogrisel commented Mar 2, 2016

README.md is used by github to build the home page of a repo. At this point the mingwpy-dev branch of our clone of the mingw-builds has mingwpy specific instructions hidden in a file named mingwpy_readme.md.

We don't want to pollute upstream mingw-builds with minwpy-specific stuff so I think it's better to gather those information in the toplevel README.md file of our own mingwpy repository.

This way the mingwpy-dev branch of our clone of the mingw-builds can be more in line with upstream mingw-builds. This branch can be considered as temporary container of patches that we plan to submit upstream to make the mingw-builds scripts generic enough for our usecase will not imposing any mingwpy specific documentation on them.

At the same time it will make it easier for people interested specifically in building the mingwpy toolchain from source to find the build instructions.

@ogrisel
Copy link
Contributor Author

ogrisel commented Mar 2, 2016

This is related to the intention to contribute to upstream mingw-build as tracked in #5 so as to keep the long term maintenance efforts of mingwpy to a minimum.

techtonik added a commit to techtonik/mingwpy that referenced this issue Mar 5, 2016
@techtonik
Copy link
Contributor

I added entrypoint README.md in PR above, but I haven't got time to read and validate the info about branch layout and handling of patch queues. Need more round tuits.

@carlkl
Copy link
Contributor

carlkl commented Mar 6, 2016

I moved the build instructions as requested.

@ogrisel
Copy link
Contributor Author

ogrisel commented Mar 7, 2016

Thanks!

@ogrisel ogrisel closed this as completed Mar 7, 2016
@ogrisel ogrisel reopened this Mar 7, 2016
@ogrisel ogrisel closed this as completed Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants