Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make new fixtures in csv2df tests #52

Closed
epogrebnyak opened this issue Aug 7, 2017 · 5 comments
Closed

make new fixtures in csv2df tests #52

epogrebnyak opened this issue Aug 7, 2017 · 5 comments

Comments

@epogrebnyak
Copy link
Collaborator

epogrebnyak commented Aug 7, 2017

This review is similar to #38.

@epogrebnyak epogrebnyak changed the title review src/kep/rows, tables, vintage review src/kep/[rows, tables, vintage] Aug 7, 2017
@epogrebnyak
Copy link
Collaborator Author

epogrebnyak commented Aug 24, 2017

48c4125 sets new file structure in src/kep2 and reduces dependencies. everything is run by runner.py + main section has own examples in each module.

Naming reference is mailman and BW style guide. Used from it: __all__, tentative 1 class per module.

Major TODO is restoring tests, but should be easier once the components are decoupled. After restoring tests will rename kep2 to kep.

@epogrebnyak
Copy link
Collaborator Author

epogrebnyak commented Aug 24, 2017

New file structure testing: (structure was changed. Ignore this comment)

  • emitter.py
  • helpers.py
  • label.py
  • parcer.py
  • reader.py
  • runner.py
  • specification.py
  • util_row_splitter.py
  • validator.py

epogrebnyak added a commit that referenced this issue Aug 24, 2017
epogrebnyak added a commit that referenced this issue Aug 24, 2017
epogrebnyak added a commit that referenced this issue Aug 24, 2017
epogrebnyak added a commit that referenced this issue Aug 24, 2017
epogrebnyak added a commit that referenced this issue Aug 24, 2017
@epogrebnyak
Copy link
Collaborator Author

epogrebnyak commented Aug 25, 2017

TODO:

  • check all csv2df/*.py modules have __all__ property.
  • check methods/classes in __all__ are tested
  • make new fixtures
  • prepare follow-up questions (xfail vs skip, ... )

@epogrebnyak epogrebnyak changed the title review src/kep/[rows, tables, vintage] make new fixtures in csv2df tests Aug 28, 2017
@bakakaldsas
Copy link
Contributor

bakakaldsas commented Aug 28, 2017

__all__ property in modules:

  • emitter.py
  • parser.py
  • reader.py
  • runner.py
  • specification.py - added empty needs to be filled
  • util_label.py
  • util_row_splitter.py - added empty needs to be filled
  • validator.py - added empty needs to be filled

@bakakaldsas
Copy link
Contributor

bakakaldsas commented Aug 28, 2017

Tests by module:

  • emitter.py:
    • Emitter
  • parser.py
    • extract_tables
  • reader.py
    • Reader (skip)
    • open_csv
  • runner.py
    • get_dataframes
    • Vintage (skip)
    • Collection (skip)
  • specification.py
    #TODO __all__
  • util_label.py
    • make_label
    • split_label
    • extract_varname
    • extract_unit
  • util_row_splitter.py
    • (tested with doctest)
  • validator.py
    #TODO __all__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants