Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when using a selector on drawableResId #6

Closed
yobijoss opened this issue Oct 17, 2017 · 3 comments
Closed

crash when using a selector on drawableResId #6

yobijoss opened this issue Oct 17, 2017 · 3 comments

Comments

@yobijoss
Copy link

If you set a selector as a drawableResId on DrawableBagde.Builder. Then app crashes and shows this error.

image

@yobijoss
Copy link
Author

yobijoss commented Oct 17, 2017

here is the code

 DrawableBadge drawable = new DrawableBadge.Builder(getContext())
                .drawableResId(R.drawable.selector_notif_bell)
                .badgeColor(R.color.colorAccent)
                .badgeSize(R.dimen.badge_size)
                .badgePosition(BadgePosition.TOP_RIGHT)
                .textColor(R.color.white)
                .showBorder(true)
                .badgeBorderColor(R.color.white)
                .badgeBorderSize(R.dimen.badge_border_size)
                .build();

@minibugdev
Copy link
Owner

Thanks for report.
On version 1.0.1 we doesn't support to set drawable with drawable selector.
I'll add this feature to next release or you can create PR to fix the issue :)

@yobijoss
Copy link
Author

This library is pretty cool and recent, If I make it to the fix I'll fire a PR hehe
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants