Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camelCased flag doesn't create a helper. #27

Closed
GCheung55 opened this issue Sep 14, 2016 · 5 comments
Closed

camelCased flag doesn't create a helper. #27

GCheung55 opened this issue Sep 14, 2016 · 5 comments

Comments

@GCheung55
Copy link

With a featureFlag in the config as isFoo, a if-flag-isFoo is missing.

@jobackman
Copy link
Contributor

Care to elaborate some? I've been using camelcased featureFlags for a long time without any trouble.

Are you getting errors or are the feature-flags not removing code like they should? If it's related to #21 try updating this addon to the lastest version and your ember-cli-htmlbars toa version that allows cachebusting.

@minichate
Copy link
Owner

@GCheung55 I can't repro this either; any chance you could submit a test case that shows the failing behaviour?

@GCheung55
Copy link
Author

Yes. I'll put a test repo together.

On Sep 23, 2016, at 8:32 AM, Christopher Troup notifications@github.com wrote:

@GCheung55 I can't repro this either; any chance you could submit a test case that shows the failing behaviour?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@minichate
Copy link
Owner

@GCheung55 Any chance you've reproduced this? I can close this issue if not. Thanks!

@GCheung55
Copy link
Author

I couldn't reproduce. Closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants