-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{{#if-flags-}} dont always reflect the featureFlags value #21
Comments
{{#if-flags-}}
dont always reflect the featureFlags
value
Hey @jobackman! Unfortunately its a known issue that I/we've been fighting with for the last couple months. What we currently do is HTMLBars heavily caches the AST after transformations are applied. We're still working on bypassing that cache, but in the meantime the best thing to do is clear out node_modules when changing code on either side of the flag. I'll leave this issue open to track progress on the issue. Thanks for reporting! |
👍 Would be awesome if you could release an updated version to npm without Otherwise very nice addon! Thanks |
@oscarni Can you try 0.4.11 and see if that works for you? |
@minichate works like a charm! Thanks for making the console clean 👍 |
Shipped in |
Hi, before I begin I'd like to commend you on a great addon, it's just what I've been wanting for our project! 👍👍
I do believe I have found an issue in the ``{{if-flag-ENABLE_FOO}}
helper though, where
featureFlags.keys` will not update the `if-flags` correctly. I tried reverse engineering it and I can continuously recreate the it now.I made a fresh dummy app to make sure it wasn't our app causing the problems, and in case anyone wants to give it a try.
How to recreate:
ember serve
and neither<h1>foo</h1>
nor<h1>bar</h1>
will show in the template and their pods aren't included in the build. Nothing wrong here.baz=foo ember serve
, thus enablingENABLE_FOO
. The app should now include the foo pod, which it does. But<h1>foo</h1>
will still not show up in the template.<h1>foo</h1>
shows and is included in the build as it should.I'm far from an expert on how you made you app how it should be made for that matter, but I noticed that the console.log spam "sdf" and "foo" (which btw are present in the npm package but not your repo) only occur when changes are made to a file in the app and saved, and thus recompiled in a new build.
I've tried removing dist and tmp, thinking caching of the build was the issue, but the end result has remained the same as long as I didn't edit files on the app.
I hope it makes sense!
The text was updated successfully, but these errors were encountered: