Replace featureFlags inline by their values when minifying #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a redundant operation for uglifyJS but it makes this library
compatible with babili's dead code eliminitation logic.
when minification is enabled
MY_FEATURE_FLAG=false
```
if (MY_FEATURE_FLAG) {
return x;
} else {
return y;
}
```
becomes
```
if (false) {
return x;
} else {
return y;
}
```
Then babili's/uglifyJS DCE logic turns this code into
```
return y;
```
|
@alexBaizeau Is this backwards compatible with Uglify users? |
|
@minichate Yes it is, it just make this line useless https://github.com/minichate/ember-cli-conditional-compile/blob/master/index.js#L30 The Global values are inlined and uglifyJS dead code elimination will kick in as well |
|
💯 |
|
@alexBaizeau Released as |
minichate
reviewed
Jun 1, 2017
| @@ -47,6 +47,8 @@ | |||
| "loader.js": "4.2.3" | |||
| }, | |||
| "dependencies": { | |||
| "babel-plugin-inline-replace-variables": "https://github.com/alexBaizeau/babel-plugin-inline-replace-variables.git#8d55becd00acca84b6f301ad346aeed9507949a3", | |||
There was a problem hiding this comment.
I believe we can use 1.3.1 now :)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redundant operation for uglifyJS but it makes this library
compatible with babili's dead code eliminitation logic.
when minification is enabled
MY_FEATURE_FLAG=false
becomes
Then babili's/uglifyJS DCE logic turns this code into
I add to pin a package to one of my commit while wssgcg1213/babel-plugin-inline-replace-variables#8 merges