Feat: custom timeout config #373
Conversation
config/config.go
Outdated
| @@ -230,12 +233,19 @@ func (c *Config) ArchiveReadDays() int { | |||
| return getIntValue("ARCHIVE_READ_DAYS", defaultArchiveReadDays) | |||
| } | |||
|
|
|||
| // RequestTimeout returns a Duration.time represent the request timeout | |||
| func (c *Config) RequestTimeout() time.Duration { | |||
| requestTimout := getIntValue("REQUEST_MAX_TIMEOUT", defaultRequestTimeout) | |||
There was a problem hiding this comment.
Maybe we can name the variable HTTP_CLIENT_TIMEOUT to be more explicit. In the future, the HTTP server timeout could be also configurable...
| // 15MB max. | ||
| maxBodySize = 1024 * 1024 * 15 | ||
| ) | ||
|
|
||
| var cfg = config.NewConfig() |
There was a problem hiding this comment.
Hum.. I should refactor this config package. This is going to parse the config values twice during the process startup.
There was a problem hiding this comment.
I thought about it when I wrote this.
It seem the config never change after the process startup. So it is OK to work though not so good. For now I cannot find out a way without parsing the config value again. Looking forward to your good news
|
Thank you for you pull-request but the In the master branch, you can now configure the HTTP client timeout with |
ghost
locked and limited conversation to collaborators
configurable timeout for bad network environment #302