Simplify DomHelper.getVisibleElements

Use a `filter` instead of a loop with an index.
miniflux · Mar 11, 2024 · fd1fee8 · fd1fee8
1 parent c51a327
commit fd1fee8
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/internal/ui/static/js/dom_helper.js b/internal/ui/static/js/dom_helper.js
@@ -22,16 +22,8 @@ class DomHelper {
     }
 
     static getVisibleElements(selector) {
-        let elements = document.querySelectorAll(selector);
-        let result = [];
-
-        for (let i = 0; i < elements.length; i++) {
-            if (this.isVisible(elements[i])) {
-                result.push(elements[i]);
-            }
-        }
-
-        return result;
+        const elements = document.querySelectorAll(selector);
+        return [...elements].filter((element) => this.isVisible(element));
     }
 
     static hasPassiveEventListenerOption() {