Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS support to API #675

Closed
a-bali opened this issue May 26, 2020 · 2 comments · Fixed by #691
Closed

Add CORS support to API #675

a-bali opened this issue May 26, 2020 · 2 comments · Fixed by #691

Comments

@a-bali
Copy link
Contributor

a-bali commented May 26, 2020

In order to enable web based applications to use the API, can you please add CORS support to it?

@captn3m0
Copy link

As an alternative, I was wondering if I could set the static asset directory for miniflux, and clone reminiflux inside the same.

So miniflux.tld/re/index.html opens up reminiflux, and since its on the same domain, CORS issue doesn't apply.

This is similar to how Transmission themes work. eg1, eg2.

@Thor77
Copy link

Thor77 commented Jun 1, 2020

(probably offtopic regarding the original issue, just referring to the suggestion from @captn3m0)

If you are running a reverse proxy in front of Miniflux you can already achieve that behaviour.
I'm using nginx and my config looks like this:

location / {
  proxy_pass http://unix:/tmp/miniflux.socket:/;
  ...
}

location /reminiflux {
  root /usr/share/nginx/reminiflux;
  index index.html;
}

You just have to set homepage in reminiflux's package.json to https://<miniflux vhost>/reminiflux before building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants