Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve category display a little #1162

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Conversation

pennae
Copy link
Contributor

@pennae pennae commented Jun 1, 2021

categories are currently a bit unfriendly to use when they contain many feeds, most of which update rarely. it's not easy to find feeds with unread entries, so it seems prudent to highlight them specially (like feeds with errors are highlighted already), and to sort feeds with unread entries before feeds without unread entries.

Do you follow the guidelines?

Copy link
Member

@fguillot fguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to have the same behavior between the feeds list page and the feeds in the category page.

/category/2/feeds:

image

/feeds:

image

Also, in Dark mode, the color looks strange to me:

image

@pennae
Copy link
Contributor Author

pennae commented Jun 2, 2021

the feeds page is untouched here because #697 stated it's intentionally unsorted for performance. could change it, but it seemed deliberate to not have it that way (and the category list loaded the unread counts anyway, so adding the sort was basically free).

as for the colors, those are what looked least displeasing here. totally open to changing them, but no idea what they should be!

@fguillot
Copy link
Member

fguillot commented Jun 2, 2021

The performance issue mentioned in #697 is about the SQL query. Your solution solve this problem because the sorting is done after fetching the feeds from the database. It seems more elegant than the Javascript solution proposed in the same discussion.

Actually, your sorting functions could be moved to the storage package: https://github.com/miniflux/v2/blob/master/storage/feed.go#L125-L141

Regarding the colors in Dark mode, I'm not very good at that, every single person will have different taste, but I would try something like that:

image

image

@pennae
Copy link
Contributor Author

pennae commented Jun 2, 2021

your colors are much better. moved the sort to the storage module, and added some css variables to make the unread highlight nicely configurable.

@fguillot fguillot merged commit 4b2a25e into miniflux:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants