Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brotli decompression to Http Client #1397

Closed
wants to merge 1 commit into from

Conversation

razielgn
Copy link

Some feeds are serving Brotli-encoded responses even when the client is not declaring such capability.
This issue was manifesting itself as Unsupported feed format on feed pages.

This PR adds the ability to decode Brotli responses, given that the Content-Encoding header is set to br (brotli).
I have picked what looks like the most up-to-date and maintained brotli library in the golang ecosystem.

@fguillot
Copy link
Member

Some feeds are serving Brotli-encoded responses even when the client is not declaring such capability.

Can you provide an example of such website?

@fguillot
Copy link
Member

@razielgn Are you still interested by this PR? I haven't seen any feed with that problem in the wild. Do you have any examples?

@somini
Copy link
Contributor

somini commented Aug 28, 2022

Didn't Google create brotli? Does go support require a third-party dependency, it's not on the standard lib?

@fguillot
Copy link
Member

My main concern with this change is another dependency has to be added to handle the Brotli compression. That seems to be a workaround for an incorrectly configured web server.

We can reconsider this if the problem is more widespread, in the meantime I will close this PR. The author didn't replied, so I don't think it's a major blocker for now.

@fguillot fguillot closed this Oct 30, 2022
@Seirdy
Copy link

Seirdy commented Aug 21, 2023

@fguillot I'd still recommend considering Brotli support. Popular sites may get hundreds or even thousands of hits from Miniflux per day, so small savings (like Brotli support) can add up fast for a feed provider. And users with hundreds (or thousands!) of feeds could enjoy faster refreshes.

@fguillot fguillot linked an issue Apr 19, 2024 that may be closed by this pull request
1 task
@fguillot
Copy link
Member

New PR #2612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Brotli compression support?
4 participants