Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transparent status bar on iOS #1667

Closed
wants to merge 1 commit into from

Conversation

kgarner7
Copy link

This is a small change to HTML to make the status bar on iOS transparent. It isn't really notable with the default themes, but is helpful for PWA when using custom CSS. Docs from Apple regarding these tags

@fguillot
Copy link
Member

The text overlap with a transparent status bar, and from my point of view it's harder to read.

Without your changes:

IMG_F98B0FCED324-1

With your changes:

IMG_9C5A262DFEF2-1

IMG_8C61CFF80BEF-1

@kgarner7
Copy link
Author

Ugh, yeah that looks bad (it looked better on a larger device). Sorry about that .-.
Probably the correct way to do this would be to add another column to user that sets the theme-color, as this is the only way to have the same status bar while not having bad transparency (I wish you could just CSS it, but alas). I'm comfortable actually making these code changes (aside from localization unfortunately), but want to ask, is this actually worthwhile?

@woj-tek
Copy link
Contributor

woj-tek commented Jan 30, 2023

The text overlap with a transparent status bar, and from my point of view it's harder to read.

Somewhat OT, but on Android with PWA via firefox and white theme status icons are completely not visible (they are white and the header is gone thus white background from Miniflux is used). Should this be considered a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants