fix: Use logical pixels for popover offset calculation

[zwett]

Fixed popover cut-off issue by adjusting physicalSize in PopoverUtils to account for devicePixelRatio. This way, on high-DPI screens, the popover uses logical pixels for offset calculation.

physicalSize	physicalSize / devicePixelRatio

Closes

• [Bug]: half of the widget is not shown #83

Summary by CodeRabbit

• Bug Fixes
  • Improved physical size calculation in popovers by considering the device pixel ratio, enhancing display accuracy on various devices.

[coderabbitai]

Walkthrough

This update revises the calculation of the physicalSize within the PopoverUtils class, now incorporating the device pixel ratio. This adjustment ensures a more accurate determination of the physical size, enhancing the overall functionality and display across different devices.

Changes

File Path	Change Summary
.../utils/popover_utils.dart	Updated physicalSize calculation in PopoverUtils to include device pixel ratio.

🐇✨
In the realm of code, where changes abound,
A tiny tweak makes the world go round.
Pixels align with a magical grace,
Thanks to a rabbit who knows their place.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 5a672f2 and 9237e95.

Files selected for processing (1)

• lib/src/utils/popover_utils.dart (1 hunks)

Additional comments: 1

lib/src/utils/popover_utils.dart (1)

• 37-38: The calculation of physicalSize now correctly accounts for the device pixel ratio by dividing the physical size by the device pixel ratio. This change ensures that offset calculations for popovers are based on logical pixels, which is crucial for correct display on high-DPI screens. Ensure that all usages of physicalSize within the application have been updated to reflect this change in calculation.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a672f2) 91.81% compared to head (9237e95) 91.83%.

❗ Current head 9237e95 differs from pull request most recent head 1f0e5c4. Consider uploading reports for the commit 1f0e5c4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   91.81%   91.83%   +0.01%     
==========================================
  Files           9        9              
  Lines         440      441       +1     
==========================================
+ Hits          404      405       +1     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[minikin]

@zwett, thank you for your contribution!
I validated this change on iOS, Android, macOS, and the Web. It solves the issue when the screen size is constant.
However, when a user changes the window size and calls showPopover again, the physicalSize is not recalculated.

Would you be willing to address it?

[zwett]

@minikin Definitely! Thanks for taking the time to check it out thoroughly. I'll look into it and get back to you with a fix asap

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9237e95 and 1f0e5c4.

Files selected for processing (1)

• lib/src/utils/popover_utils.dart (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• lib/src/utils/popover_utils.dart

[zwett]

@minikin Switching physicalSize to a getter appears to solve our problem. Please don't hesitate to ping me if I've overlooked something again 🙈

resize-popover-position.mp4

[minikin]

@zwett, it works, thank you 🚀 I'll release a new version tomorrow.