Add cmd status to exception (#542)

minimagick · May 26, 2022 · 42e9d01 · 42e9d01
1 parent 39b3ed4
commit 42e9d01
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/mini_magick/shell.rb b/lib/mini_magick/shell.rb
@@ -14,7 +14,7 @@ def run(command, options = {})
       stdout, stderr, status = execute(command, stdin: options[:stdin])
 
       if status != 0 && options.fetch(:whiny, MiniMagick.whiny)
-        fail MiniMagick::Error, "`#{command.join(" ")}` failed with error:\n#{stderr}"
+        fail MiniMagick::Error, "`#{command.join(" ")}` failed with status: #{status} and error:\n#{stderr}"
       end
 
       $stderr.print(stderr) unless options[:stderr] == false

diff --git a/spec/lib/mini_magick/shell_spec.rb b/spec/lib/mini_magick/shell_spec.rb
@@ -15,10 +15,13 @@
       expect(output).to eq ["stdout", "stderr", 0]
     end
 
-    it "uses stderr for error messages" do
+    it "uses stderr and status for error messages" do
       allow(subject).to receive(:execute).and_return(["", "stderr", 1])
+
+      expected_msg = "`foo` failed with status: 1 and error:\nstderr"
+
       expect { subject.run(%W[foo]) }
-        .to raise_error(MiniMagick::Error, /`foo`.*stderr/m)
+        .to raise_error(MiniMagick::Error, expected_msg)
     end
 
     it "raises an error when executable wasn't found" do