Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long option followed by single dash #17

merged 1 commit into from Feb 9, 2023


Copy link

A single dash is used with some utilities to represent stdin/stdout, as an argument or as an option value. Minimist was allowing a single dash as a space-separated value for a short option but not for a long option.

Fixes #15

This PR uses the same pattern for checking a potential long-option value as already being used for checking the short-option value. In particular, this means a single dash is now accepted as an option value when used like:

util --foo -

Copy link

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

index.js Show resolved Hide resolved
test/dash.js Outdated Show resolved Hide resolved
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #17 (9ec4d27) into main (ba92fe6) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #17   +/-   ##
  Coverage   98.75%   98.75%           
  Files           1        1           
  Lines         161      161           
  Branches       71       71           
  Hits          159      159           
  Misses          2        2           
Impacted Files Coverage Δ
index.js 98.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

- can not be string value
4 participants