Fix log parsing for DNF5 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on logs from some of the first builds with DNF5, there are a couple differences in root.log that matter to our parser. First, the NVR is quoted in the "already installed" message: - Package coreutils-9.4-1.fc40.x86_64 is already installed. + Package "coreutils-9.4-1.fc40.x86_64" is already installed. Second, IEC abbreviations are used when describing package sizes (and there also seems to be a change from download size to installed size, not that the number matters here): - make x86_64 1:4.4.1-2.fc39 build 579 k + make x86_64 1:4.4.1-2.fc39 build 1.8 MiB
|
/cc @asamalik @sgallagher |
sgallagher
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on logs from some of the first builds with DNF5, there are a couple differences in root.log that matter to our parser.
First, the NVR is quoted in the "already installed" message:
Second, IEC abbreviations are used when describing package sizes (and there also seems to be a change from download size to installed size, not that the number matters here):