Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xero partner applications #4

Open
rikkipitt opened this issue Oct 10, 2019 · 6 comments
Open

Xero partner applications #4

rikkipitt opened this issue Oct 10, 2019 · 6 comments

Comments

@rikkipitt
Copy link

Hi @minimul,

I'm using your library (and extending it slightly) to cover a bit more than just the accounting endpoints from Xero. It's working well, thank you.

I was wondering how I now convert my connection to use the Xero partner app, specifically the private certificate etc? The readme mentions xero-api works with partner apps but I can't seem to find any documentation regarding it...

Cheers for the help,
Rikki

@minimul
Copy link
Owner

minimul commented Oct 11, 2019

I'll have to change the README for false advertising. :)

Would you be able to add that support in?

Thanks @rikkipitt

@rikkipitt
Copy link
Author

Oh no! Haha, thanks for confirming my suspicions though, appreciated.

Since I raised this issue, I've been investigating the best way to handle partner apps. I'll carry on and see what I can do. Do you happen to have a partner app on Xero yourself for testing purposes? I'm just in the process of getting my second one fully vetted by Xero, so let me know if you'd like to pair etc on my project if it'll help.

Best,
Rikki

@minimul
Copy link
Owner

minimul commented Oct 12, 2019

I had a consulting gig to do a Xero integration but it dissolved so I am not using the gem in production and never went deep into the partner app process.

I did run the VCR specs against the Xero test/sandbox account.

I do have a potential Xero integration project in the works so I am interested in keeping this gem going strong but I'll need to support from you, @blahutka, and others.

I'd be interested in PRs around some of your extensions you mentioned in the first post too.

With regards to pairing – sure – I'd mostly be learning from you but two heads are better than one.

@rikkipitt
Copy link
Author

Good timing, I'm just looking into this now.

To keep the Faraday based flexibility of your gem, which is one of the main reasons I'm using this over the other approaches in the space, I propose we use something like this: https://github.com/notEthan/oauthenticator

What are your thoughts? Shall I give it a whirl?

The updates I mentioned were rudimentary extensions within my app to allow for the use of other aspects of the Xero API (e.g. Payroll, Files etc). I'll see if I can build them into a proper PR at some point.

I'll create a new branch for this partner auth work now.

Best,
Rikki

@minimul
Copy link
Owner

minimul commented Oct 12, 2019

Yes, that approach looks good.

I'll also request partner app access from Xero so I can aid in testing your PR and other future additions.

@rikkipitt
Copy link
Author

Thanks, that'll be super helpful. I've got a rough idea of how I'd tackle this. I've run through your setup docs and encountered the expected partner error I am getting within my app:

unexpected token at 'oauth_problem=signature_method_rejected&oauth_problem_advice=Partner%20applications%20must%20use%20RSA-SHA1%20signature%20method'

My app is a side project of mine but this is a priority for it to continue on its way through the Xero onboarding process. I'll carry on and try and get something ready for you to review and test soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants