Expiry cannot be larger than 7 days

[breml]

Expected behaviour

Create share URLs with expiry periods larger than 7 days.

Actual behaviour

The 7 days limit is hard coded in mc (as well as minio-go, see minio/minio-go#594)

Steps to reproduce the behaviour

Create a share URL with an expriy period longer than 7 days.

mc share download -E 1000h test/test-bucket/test-file

mc version

current master

System information

[harshavardhana]

@breml Expiry of 7days is an S3 API limit - we are following S3 standards http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-query-string-auth.html.

[breml]

OK, understood.

But why are you enforcing the limit within the tool it self and do net let the API respond with an error if a user decides to use a larger expiry period? In this case, mc would also work with other S3 backends and would allow to use other expiry periods, if supported by the backend (maybe even Amazon will change this limit in the future).

Don't you have any intention to make mc useful with S3 backends other than Amazon?

[harshavardhana]

But why are you enforcing the limit within the tool it self and do net let the API respond with an error if a user decides to use a larger expiry period?

This is a bad design choice all input arguments should be validated up-front to the published API limits and not confuse users by behaving differently under different situations. In future if Amazon S3 changes this limit then we would change too.

Don't you have any intention to make mc useful with S3 backends other than Amazon?

mcs intention is to work with Minio, Amazon S3 and all other S3 compatible backends.