Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing filter rules in output of ilm list #3389

Closed
findmyname666 opened this issue Aug 31, 2020 · 5 comments
Closed

missing filter rules in output of ilm list #3389

findmyname666 opened this issue Aug 31, 2020 · 5 comments
Assignees

Comments

@findmyname666
Copy link

Expected behavior

Subcommand mc ilm list shows filter rule(s) for lifecycle rule(s).
I would bet that it worked correctly in older versions.
Not really sure whether it is mc or minio bug but so far object expiration seems to be set correctly:

# this object should expire in two weeks
# smc stat some_path
Name      : some_path
Date      : 2020-08-18 20:34:53 UTC 
Size      : 26 GiB 
ETag      : cd5b3dcc43f1472a9ea48933f9d67745-209 
Type      : file 
Expiration: 2020-09-02 00:00:00 UTC (lifecycle-rule-id: 2week) 
Metadata  :
  Content-Type       : application/octet-stream 
  X-Amz-Tagging-Count: 1

Actual behavior

Filter rules are empty for lifecycle rule(s).

Steps to reproduce the behavior

  1. create lifecycle rule(s) with filter section, example rules:
{"Rules":[{"Expiration":{"Days":7},"ID":"1week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":14},"ID":"2week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":21},"ID":"3week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":28},"ID":"4week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":35},"ID":"5week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":42},"ID":"6week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":49},"ID":"7week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":56},"ID":"8week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":63},"ID":"9week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":70},"ID":"10week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":77},"ID":"11week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":84},"ID":"12week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":91},"ID":"13week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":98},"ID":"14week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":105},"ID":"15week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":112},"ID":"16week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":119},"ID":"17week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":126},"ID":"18week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":133},"ID":"19week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":140},"ID":"20week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":147},"ID":"21week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":154},"ID":"22week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":161},"ID":"23week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":168},"ID":"24week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":175},"ID":"25week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":182},"ID":"26week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":189},"ID":"27week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":196},"ID":"28week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":203},"ID":"29week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":210},"ID":"30week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":217},"ID":"31week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":224},"ID":"32week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":231},"ID":"33week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":238},"ID":"34week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":245},"ID":"35week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":252},"ID":"36week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":259},"ID":"37week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":266},"ID":"38week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":273},"ID":"39week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":280},"ID":"40week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":287},"ID":"41week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":294},"ID":"42week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":301},"ID":"43week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":308},"ID":"44week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":315},"ID":"45week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":322},"ID":"46week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":329},"ID":"47week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":336},"ID":"48week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":343},"ID":"49week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":350},"ID":"50week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":357},"ID":"51week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":364},"ID":"52week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":371},"ID":"53week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":378},"ID":"54week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":385},"ID":"55week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":392},"ID":"56week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":399},"ID":"57week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":406},"ID":"58week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":413},"ID":"59week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":420},"ID":"60week","Filter":{},"Status":"Enabled"},{"Expiration":{"Days":427},"ID":"61week","Filter":{},"Status":"Enabled"}]}
  1. list lifecycle rule smc ilm list minio_name/bucket_name --json
# smc ilm list minio_name/bucket_name --json &> /tmp/ilm 
# head /tmp/ilm 
{"status":"success","target":"minio_name/bucket_name","config":{"Rules":[{"AbortIncompleteMultipartUpload":{},"Expiration":{"Date":"0001-01-01T00:00:00Z","Days":7,"DeleteMarker":false},"ID":"1week","Filter":{"And":{}},"NoncurrentVersionExpiration":{"NoncurrentDays":0},"NoncurrentVersionTransition":{},"Status":"Enabled","Transition":{"Date":"0001-01-01T00:00:00Z"}},{"AbortIncompleteMultipartUpload":{},"Expiration":{"Date":"0001-01-01T00:00:00Z","Days":14,"DeleteMarker":false},"ID":"2week","Filter":{"And":{}},"NoncurrentVersionExpiration":{"NoncurrentDays":0},"NoncurrentVersionTransition":{},"Status":"Enabled","Transition":{"Date":"0001-01-01T00:00:00Z"}},{"AbortIncompleteMultipartUpload":{}

mc --version

  • (paste output of mc --version)
    mc version RELEASE.2020-08-20T00-23-01Z

server version: minio version ELEASE.2020-08-27T05-16-20Z`

System information

Debian Buster

@vadmeste
Copy link
Member

vadmeste commented Sep 1, 2020

@findmyname666 in the first step in Steps to reproduce, Filter is not set at all, and if I understood your description correctly, you are saying that Filter is lost when you download the lifecycle document from the server

@findmyname666
Copy link
Author

findmyname666 commented Sep 1, 2020

Hi @vadmeste,

you are saying that Filter is lost when you download the lifecycle document from the server

Yes you are right. I uploaded wrong example e.g. there is export of wrong LC.
To be more specific there is missing Tag section in Filter definition.
Test Lifecycle config should look like:

<LifecycleConfiguration><Rule><ID>1week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>1</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>7</Days></Expiration></Rule><Rule><ID>2week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>2</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>14</Days></Expiration></Rule><Rule><ID>3week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>3</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>21</Days></Expiration></Rule><Rule><ID>4week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>4</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>28</Days></Expiration></Rule><Rule><ID>5week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>5</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>35</Days></Expiration></Rule><Rule><ID>6week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>6</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>42</Days></Expiration></Rule><Rule><ID>7week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>7</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>49</Days></Expiration></Rule><Rule><ID>8week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>8</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>56</Days></Expiration></Rule><Rule><ID>9week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>9</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>63</Days></Expiration></Rule><Rule><ID>10week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>10</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>70</Days></Expiration></Rule><Rule><ID>11week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>11</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>77</Days></Expiration></Rule><Rule><ID>12week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>12</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>84</Days></Expiration></Rule><Rule><ID>13week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>13</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>91</Days></Expiration></Rule><Rule><ID>14week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>14</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>98</Days></Expiration></Rule><Rule><ID>15week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>15</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>105</Days></Expiration></Rule><Rule><ID>16week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>16</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>112</Days></Expiration></Rule><Rule><ID>17week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>17</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>119</Days></Expiration></Rule><Rule><ID>18week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>18</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>126</Days></Expiration></Rule><Rule><ID>19week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>19</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>133</Days></Expiration></Rule><Rule><ID>20week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>20</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>140</Days></Expiration></Rule><Rule><ID>21week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>21</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>147</Days></Expiration></Rule><Rule><ID>22week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>22</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>154</Days></Expiration></Rule><Rule><ID>23week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>23</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>161</Days></Expiration></Rule><Rule><ID>24week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>24</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>168</Days></Expiration></Rule><Rule><ID>25week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>25</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>175</Days></Expiration></Rule><Rule><ID>26week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>26</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>182</Days></Expiration></Rule><Rule><ID>27week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>27</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>189</Days></Expiration></Rule><Rule><ID>28week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>28</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>196</Days></Expiration></Rule><Rule><ID>29week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>29</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>203</Days></Expiration></Rule><Rule><ID>30week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>30</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>210</Days></Expiration></Rule><Rule><ID>31week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>31</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>217</Days></Expiration></Rule><Rule><ID>32week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>32</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>224</Days></Expiration></Rule><Rule><ID>33week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>33</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>231</Days></Expiration></Rule><Rule><ID>34week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>34</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>238</Days></Expiration></Rule><Rule><ID>35week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>35</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>245</Days></Expiration></Rule><Rule><ID>36week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>36</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>252</Days></Expiration></Rule><Rule><ID>37week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>37</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>259</Days></Expiration></Rule><Rule><ID>38week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>38</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>266</Days></Expiration></Rule><Rule><ID>39week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>39</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>273</Days></Expiration></Rule><Rule><ID>40week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>40</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>280</Days></Expiration></Rule><Rule><ID>41week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>41</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>287</Days></Expiration></Rule><Rule><ID>42week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>42</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>294</Days></Expiration></Rule><Rule><ID>43week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>43</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>301</Days></Expiration></Rule><Rule><ID>44week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>44</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>308</Days></Expiration></Rule><Rule><ID>45week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>45</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>315</Days></Expiration></Rule><Rule><ID>46week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>46</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>322</Days></Expiration></Rule><Rule><ID>47week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>47</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>329</Days></Expiration></Rule><Rule><ID>48week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>48</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>336</Days></Expiration></Rule><Rule><ID>49week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>49</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>343</Days></Expiration></Rule><Rule><ID>50week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>50</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>350</Days></Expiration></Rule><Rule><ID>51week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>51</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>357</Days></Expiration></Rule><Rule><ID>52week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>52</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>364</Days></Expiration></Rule><Rule><ID>53week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>53</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>371</Days></Expiration></Rule><Rule><ID>54week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>54</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>378</Days></Expiration></Rule><Rule><ID>55week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>55</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>385</Days></Expiration></Rule><Rule><ID>56week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>56</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>392</Days></Expiration></Rule><Rule><ID>57week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>57</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>399</Days></Expiration></Rule><Rule><ID>58week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>58</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>406</Days></Expiration></Rule><Rule><ID>59week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>59</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>413</Days></Expiration></Rule><Rule><ID>60week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>60</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>420</Days></Expiration></Rule><Rule><ID>61week</ID><Filter><Prefix></Prefix><Tag><Key>weekly_expiration</Key><Value>61</Value></Tag></Filter><Status>Enabled</Status><Expiration><Days>427</Days></Expiration></Rule></LifecycleConfiguration>

Sorry for that and thanks for looking on it.

@vadmeste
Copy link
Member

vadmeste commented Sep 1, 2020

@findmyname666, this PR should fix it: minio/minio-go#1381, hope it will be released in the next release cycle soon.

@findmyname666
Copy link
Author

@vadmeste cool TY

@vadmeste
Copy link
Member

vadmeste commented Oct 7, 2020

Fixed in the latest release, after upgrading minio-go dependency to include this fix, https://github.com/minio/minio-go/pull/1381/files

Closing this.

@vadmeste vadmeste closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants