Optimize scalar and avx2 implementations #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use https://github.com/animetosho/md5-optimisation#dependency-shortcut-in-g-function and https://github.com/animetosho/md5-optimisation#h-function-re-use for shorter dependency chain. Cleanup in AVX2 removing superfluous loads/moves. ``` benchmark old ns/op new ns/op delta BenchmarkAvx2/32KB-32 201378 194863 -3.24% BenchmarkAvx2/64KB-32 321507 303803 -5.51% BenchmarkAvx2/128KB-32 594137 577175 -2.85% BenchmarkAvx2/256KB-32 1089630 1014160 -6.93% BenchmarkAvx2/512KB-32 2077582 1959077 -5.70% BenchmarkAvx2/1MB-32 4191188 3949610 -5.76% BenchmarkAvx2/2MB-32 8439181 8042106 -4.71% BenchmarkAvx2/4MB-32 16655067 15739187 -5.50% BenchmarkAvx2/8MB-32 33017781 31620932 -4.23% BenchmarkAvx2SingleWriter/32KB-32 41765 39763 -4.79% BenchmarkAvx2SingleWriter/64KB-32 81884 76866 -6.13% BenchmarkAvx2SingleWriter/128KB-32 166802 155819 -6.58% BenchmarkAvx2SingleWriter/256KB-32 329145 306292 -6.94% BenchmarkAvx2SingleWriter/512KB-32 653422 616564 -5.64% BenchmarkAvx2SingleWriter/1MB-32 1303555 1237368 -5.08% BenchmarkAvx2SingleWriter/2MB-32 2596346 2441836 -5.95% BenchmarkAvx2SingleWriter/4MB-32 5151380 4885766 -5.16% BenchmarkAvx2SingleWriter/8MB-32 10324461 9765875 -5.41% ```
harshavardhana
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://github.com/animetosho/md5-optimisation#dependency-shortcut-in-g-function and https://github.com/animetosho/md5-optimisation#h-function-re-use for shorter dependency chain.
Cleanup in AVX2 removing superfluous loads/moves.