Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is reference to Newtonsoft.Json necessary? #725

Closed
Sergey-Terekhin opened this issue Dec 9, 2022 · 0 comments · Fixed by #732
Closed

Question: Is reference to Newtonsoft.Json necessary? #725

Sergey-Terekhin opened this issue Dec 9, 2022 · 0 comments · Fixed by #732
Labels

Comments

@Sergey-Terekhin
Copy link

Sergey-Terekhin commented Dec 9, 2022

Hi!

Found that fresh versions of Minio client depend on the Newtonsoft.Json package. Is it necessary? Or it could be replaced by internal parser/serializer (for example, minimal. but working code can be taken here: https://github.com/zanders3/json/tree/master/src)? Seems that json is required only in some simple cases

My motivation is to reduce referenced packages as much as possible to reduce version conflicts and usage of potentially vulnerable dependencies.

I could make such PR if it was useful

Update: I've found in the class MinioNotificationRaw comment that Minio client doesn't depend on a JSON library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants