Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the amount of readable data from response body, honor content-length in response headers. #296

Closed
harshavardhana opened this issue Jan 4, 2016 · 1 comment

Comments

@harshavardhana
Copy link
Member

No description provided.

@harshavardhana harshavardhana changed the title Edit New issue Limit the amount of readable data from response body, honor content-length in response headers. Limit the amount of readable data from response body, honor content-length in response headers. Jan 8, 2016
@harshavardhana
Copy link
Member Author

Looks like Content-Length is not set for all the S3 call replies, there is no easier and effective way to verify server sending malicious data right now, since S3 itself doesn't set Content-Length.

The reason is also i think they don't set Content-Length is since server is sending data with Transfer-Encoding set to 'chunked' . Because of this reason they do not have to. Since they guarantee that server is sending in chunks not as one large blobs for client to consume. So i think we can defer the handling of response bodies for now.. Since for chunked transfer-encoding Content-Length will not be set and we cannot effectively limit and verify this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant