Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for context.Context? #700

Closed
fd0 opened this issue Jun 3, 2017 · 3 comments
Closed

Support for context.Context? #700

fd0 opened this issue Jun 3, 2017 · 3 comments
Assignees
@poornas
Labels
priority: medium
Milestone
Current

Comments

@fd0
Copy link
Contributor

fd0 commented Jun 3, 2017

Hi,

are there plans to support request cancellation via context.Context? I'm currently in the progress of adding proper cancellation to restic, and I'd like to be able to cancel outgoing requests to the s3 backend...

Cheers,
Alex
@harshavardhana
Copy link
Member

We will discuss this internally again. While there are some benefits of doing this. We are actually of the opinion that context package just complicates the codebase.

Will let you know our final decision.

@deekoder deekoder added this to the Current milestone Jun 5, 2017
@harshavardhana
Copy link
Member

This issue is not blocked any more.. We decided to implement PutObjectWithContext() and GetObjectWithContext() API.

@fd0
Copy link
Contributor Author

fd0 commented Jun 27, 2017

Nice! I'm looking forward to it!

@deekoder deekoder removed the blocked label Jun 27, 2017
@poornas poornas mentioned this issue Jul 16, 2017
Closed
@poornas poornas mentioned this issue Sep 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poornas poornas

Labels
priority: medium
Projects
None yet
Milestone
Current
Development

No branches or pull requests
4 participants
@fd0 @harshavardhana @poornas @deekoder