Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE in indirect dependency via okhttp #1489

Closed
svdo opened this issue Sep 22, 2023 · 3 comments
Closed

CVE in indirect dependency via okhttp #1489

svdo opened this issue Sep 22, 2023 · 3 comments

Comments

@svdo
Copy link

svdo commented Sep 22, 2023

Hi,

Thanks for minio-java, we enjoy using it!

Dependency-check is reporting a vulnerability (has been for a while, but I didn't get around to reporting it) in okio, via okhttp. Our partial dependency tree:

  . io.minio/minio 8.5.6
    . com.squareup.okhttp3/okhttp 4.11.0
      . com.squareup.okio/okio 3.2.0

Dependency-check output:

[CVE-2023-3635](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-3635)  suppress

GzipSource does not handle an exception that might be raised when parsing a malformed gzip buffer. This may lead to denial of service of the Okio client when handling a crafted GZIP archive, by using the GzipSource class.

CWE-681 Incorrect Conversion between Numeric Types

CVSSv3:
Base Score: HIGH (7.5)
Vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

References:
MISC - https://github.com/square/okio/commit/81bce1a30af244550b0324597720e4799281da7b
MISC - https://research.jfrog.com/vulnerabilities/okio-gzip-source-unhandled-exception-dos-xray-523195/
OSSINDEX - [[CVE-2023-3635] CWE-681: Incorrect Conversion between Numeric Types](https://ossindex.sonatype.org/vulnerability/CVE-2023-3635?component-type=maven&component-name=com.squareup.okio%2Fokio&utm_source=dependency-check&utm_medium=integration&utm_content=8.4.0)
OSSIndex - http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-3635
OSSIndex - https://github.com/square/okio/pull/1280
Vulnerable Software & Versions:

[cpe:2.3:a:squareup:okio:*:*:*:*:*:*:*:* versions up to (excluding) 3.4.0](https://web.nvd.nist.gov/view/vuln/search-results?adv_search=true&cves=on&cpe_version=cpe%3A%2Fa%3Asquareup%3Aokio)

The folks at okhttp don't seem to want to roll a release to update their okio dependency. We can of course all do it in our own projects, but maybe it would be nice for minio-java to override this dependency to okio 3.5.0?

Thank you for your consideration!

@inuyasha82
Copy link
Contributor

hopefully #1503 should fix it.

@inuyasha82
Copy link
Contributor

inuyasha82 commented Nov 17, 2023

I can confirm that after updating to minio 8.5.7 (PR #1503) the vulnerability has been fixed.

Here a screenshot of a whitesource vulnerability report:
image

@balamurugana
Copy link
Member

Fixed by #1503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants