Add python 3.11 support #1253

fedepad · 2022-12-20T14:22:21Z

The core dependencies used by this package seem to be running with Python version 3.11 (more checks might be due).
This is an attempt to bump the test matrix and fix a warning regarding the deprecation of HTTPResponse.getheader()
Here the warning I was getting:

DeprecationWarning: HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTResponse.headers.get(name, default).

Here my environment:
MacOS 13.0.1 (M1 chip),
Anaconda Python version 3.11
and here the result of pip list

Package           Version
----------------- ---------
astroid           2.12.13
attrs             22.1.0
autopep8          2.0.1
certifi           2022.12.7
dill              0.3.6
iniconfig         1.1.1
isort             5.11.3
lazy-object-proxy 1.8.0
mccabe            0.7.0
packaging         22.0
pip               22.3.1
platformdirs      2.6.0
pluggy            1.0.0
pycodestyle       2.10.0
pylint            2.15.9
pytest            7.2.0
setuptools        65.6.3
tomlkit           0.11.6
urllib3           1.26.13
wheel             0.38.4
wrapt             1.14.1

* Update the Python versions test matrix for CI tests * Update setup.py to include Python 3.11 version in the classifiers list

Reason: when running tests I got DeprecationWarning: HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTResponse.headers.get(name, default).

balamurugana · 2022-12-20T14:39:05Z

minio/api.py

@@ -166,7 +166,7 @@ def _handle_redirect_response(
            307: ("Redirect", "Temporary redirect"),
            400: ("BadRequest", "Bad request"),
        }.get(response.status, (None, None))
-        region = response.getheader("x-amz-bucket-region")
+        region = response.headers.get("x-amz-bucket-region")


This PR #1249 fixed and passed CI on Ubuntu and Windows. You would need to add macos in Github workflow to get it passed.

Ok, will add the github workflow with macos-latest like the others although it's not clear the architecture (https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md, I assume still Intel if not specified there...)

* This file adds a GitHub workflow for macos runners. It uses the latest available mac os in the GitHub runners, which might not be the latest OS released to the public. Here is assumed a Mac with Intel chip, since through simple CTRL+F the page https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md didn't show reference to M1 chips

fedepad · 2022-12-20T15:23:52Z

Removed the action codespell-project/actions-codespell@master from macos workflow as the CI complained that it is supported only on Linux.

fedepad · 2022-12-20T16:20:49Z

@balamurugana Any idea about this error: https://github.com/minio/minio-py/actions/runs/3741803675/jobs/6352419060#step:7:21 ?
On my mac functional tests seem to all pass and the log of the action is not pointing to a specific.

balamurugana · 2022-12-20T16:25:45Z

@balamurugana Any idea about this error: https://github.com/minio/minio-py/actions/runs/3741803675/jobs/6352419060#step:7:21 ? On my mac functional tests seem to all pass and the log of the action is not pointing to a specific.

You would need to brew install wget and other required dependencies.

* Install wget if it doesn't exist

* wget seems to exit with code 5 which is SSL verification failure: https://www.gnu.org/software/wget/manual/wget.html#Basic-Startup-Options

* Try if installing the ca-certificates via Homebrew for mac os runs solves the wget problem

balamurugana · 2022-12-21T00:42:11Z

.github/workflows/pythonpackage-macos.yml

+        if ! [ -x "$(command -v wget)" ]; then
+          brew install wget
+        fi
+    - name: Run functional tests


You could remove functional tests task entirely including above wget install. It is OK not to run in macos now.

Sure, will do it! It looks like was an error with self-signed certificates that prevents the download, probably a bit more work to do to have it run...

wget -v -O /tmp/minio https://dl.min.io/server/minio/release/darwin-amd64/minio --2022-12-21 00:35:11-- https://dl.min.io/server/minio/release/darwin-amd64/minio Resolving dl.min.io (dl.min.io)... 138.68.11.125, 178.1[28](https://github.com/minio/minio-py/actions/runs/3743960059/jobs/6359613951#step:8:29).69.202 Connecting to dl.min.io (dl.min.io)|138.68.11.125|:443... connected. ERROR: cannot verify dl.min.io's certificate, issued by ‘CN=Sectigo RSA Domain Validation Secure Server CA,O=Sectigo Limited,L=Salford,ST=Greater Manchester,C=GB’: Self-signed certificate encountered. To connect to dl.min.io insecurely, use `--no-check-certificate'.

* Remove as per comment, functional tests to run on macos-latest GitHub runner image. wget was blocked because a self-signed certificate needs to be trusted (pass the path if already in the machine) or installed.

Related: * macos-latest can currently be associated with either macos-11 or macos-12, so pinned it for the moment --> https://github.blog/changelog/2022-10-03-github-actions-jobs-running-on-macos-latest-are-now-running-on-macos-12/ * Update checkout actions and setup python actions versions * Tools not installed in PATH locations: actions/runner-images#6507 * Explicit export workaround for the only case that seems to fail (for PATH not found reasons): add PATH missing to PATH if os is macos-12 (the one pinned) and running Python 3.11

fedepad · 2023-01-03T14:43:11Z

I changed something in the macos workflow due to issues from GitHub already documented in the commit message plus aligned to current master.
I would give that maybe a try, even if the builds/tests for windows and linux seems ok even for Python 3.11.

* add export in macos runner for Python version < 3.11

fedepad · 2023-01-03T15:14:43Z

Re-added the user local PATH to the Python versions < 3.11 that I mistakenly removed for macos runs. Sorry

Ref: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path

harshavardhana

👍🏼 🍰

fedepad added 2 commits December 20, 2022 15:12

Bump to Python 3.11

48d14cc

* Update the Python versions test matrix for CI tests * Update setup.py to include Python 3.11 version in the classifiers list

Fix HTTPResponse.getheader() future deprecation

9a47406

Reason: when running tests I got DeprecationWarning: HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTResponse.headers.get(name, default).

balamurugana requested changes Dec 20, 2022

View reviewed changes

balamurugana changed the title ~~Bump to python 311~~ Add python 3.11 support Dec 20, 2022

fedepad added 2 commits December 20, 2022 16:01

Remove action that is only supported on Linux

cd7e5e2

fedepad added 3 commits December 20, 2022 19:39

Install wget if it doesn't exist

cabe562

* Install wget if it doesn't exist

Verbose wget for Mac OS runs to debug CI failure

7c96603

* wget seems to exit with code 5 which is SSL verification failure: https://www.gnu.org/software/wget/manual/wget.html#Basic-Startup-Options

Install ca-certificates on mac os

56faf1c

* Try if installing the ca-certificates via Homebrew for mac os runs solves the wget problem

balamurugana reviewed Dec 21, 2022

View reviewed changes

fedepad added 3 commits December 21, 2022 11:59

Remove functional tests from macos CI

4e79de9

* Remove as per comment, functional tests to run on macos-latest GitHub runner image. wget was blocked because a self-signed certificate needs to be trusted (pass the path if already in the machine) or installed.

Merge branch 'master' into bump-to-python-311

6aa7f9f

Different PATH in macos for Python < 3.11

c239cdb

* add export in macos runner for Python version < 3.11

fedepad added 2 commits January 3, 2023 16:29

Explicit PATH setting for macos-12

ca9c01e

Add system paths using docs instructions

880d26a

Ref: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path

balamurugana approved these changes Jan 3, 2023

View reviewed changes

harshavardhana approved these changes Jan 7, 2023

View reviewed changes

harshavardhana merged commit 3d5f326 into minio:master Jan 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add python 3.11 support #1253

Add python 3.11 support #1253

fedepad commented Dec 20, 2022

balamurugana Dec 20, 2022

fedepad Dec 20, 2022 •

edited

fedepad Dec 20, 2022

fedepad commented Dec 20, 2022

fedepad commented Dec 20, 2022

balamurugana commented Dec 20, 2022

balamurugana Dec 21, 2022

fedepad Dec 21, 2022

fedepad Dec 21, 2022

fedepad commented Jan 3, 2023

fedepad commented Jan 3, 2023

harshavardhana left a comment

Add python 3.11 support #1253

Add python 3.11 support #1253

Conversation

fedepad commented Dec 20, 2022

balamurugana Dec 20, 2022

Choose a reason for hiding this comment

fedepad Dec 20, 2022 • edited

Choose a reason for hiding this comment

fedepad Dec 20, 2022

Choose a reason for hiding this comment

fedepad commented Dec 20, 2022

fedepad commented Dec 20, 2022

balamurugana commented Dec 20, 2022

balamurugana Dec 21, 2022

Choose a reason for hiding this comment

fedepad Dec 21, 2022

Choose a reason for hiding this comment

fedepad Dec 21, 2022

Choose a reason for hiding this comment

fedepad commented Jan 3, 2023

fedepad commented Jan 3, 2023

harshavardhana left a comment

Choose a reason for hiding this comment

fedepad Dec 20, 2022 •

edited