fix: Ignore audit config not found error when removing the log subsystem #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operator can be in a weird state when removing the log from the tenant yaml. If removing the audit webhook succeed but the removal of the log service fails, the operator will enter in an loop of errors because it is not ignoring 'config not found' error when deleting the webhook config again in the next try. The commit ignores XMinioConfigError and XMinioConfigNotFoundError though XMinioConfigError is not returned when a config is not found since MinIO server Dec 2022.
dilverse
approved these changes
Dec 15, 2022
harshavardhana
approved these changes
Dec 15, 2022
harshavardhana
pushed a commit
that referenced
this pull request
Jan 3, 2023
…tem (#1350) The operator can be in a weird state when removing the log from the tenant yaml. If removing the audit webhook succeed but the removal of the log service fails, the operator will enter in an loop of errors because it is not ignoring 'config not found' error when deleting the webhook config again in the next try. The commit ignores XMinioConfigError and XMinioConfigNotFoundError though XMinioConfigError is not returned when a config is not found since MinIO server Dec 2022. Co-authored-by: Anis Elleuch <anis@min.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator can be in a weird state when removing the log from the tenant yaml. If removing the audit webhook succeed but the removal of the log service fails, the operator will enter in an loop of errors because it is not ignoring 'config not found' error when deleting the webhook config again in the next try.
The commit ignores XMinioConfigError and XMinioConfigNotFoundError though XMinioConfigError is not returned when a config is not found since MinIO server Dec 2022.