Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix --kubeconfig parameter for kubectl-minio proxy command #1369

Merged
merged 1 commit into from
Dec 13, 2022
Merged

bugfix --kubeconfig parameter for kubectl-minio proxy command #1369

merged 1 commit into from
Dec 13, 2022

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Dec 13, 2022 •
edited

  • add kubeconfig flag to proxy command, a scond call to kubectl was missing the parameter
  • little refactor to simpify command parameters

Closes #1364

@pjuarezd
* add kubeconfig flag to proxy command
27e68c4 
* little refactor to simpify command parameters
@pjuarezd pjuarezd merged commit 0689133 into minio:master Dec 13, 2022
@pjuarezd pjuarezd deleted the kubeconfig-flag branch December 13, 2022 23:07
@astingengo
Copy link

@pjuarezd can you please create another build that will include this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--kubeconfig flag ignored on proxy command
4 participants
@pjuarezd @astingengo @harshavardhana @dvaldivia