Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of startupProbe in containers created using Helm #1370

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

allanrogerr
Copy link
Contributor

Startup probe has been implemented as part of the Helm install. This functionality will be available in the next release. This probe may be added as part of operator/helm/tenant/values.yaml. See example value content below:

  # Startup Probe for container startup. Container will be restarted if the probe fails.
  # Refer https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
  startup:
    tcpSocket:
      port: 9000
    initialDelaySeconds: 15
    timeoutSeconds: 10
    periodSeconds: 20
    successThreshold: 1
    failureThreshold: 2

After a helm install with the above example startup probe, the containers will register:

startupProbe:
      failureThreshold: 2
      initialDelaySeconds: 15
      periodSeconds: 20
      successThreshold: 1
      tcpSocket:
        port: 9000
      timeoutSeconds: 10

Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dilverse dilverse linked an issue Dec 15, 2022 that may be closed by this pull request
@dilverse dilverse merged commit 15a8eb4 into master Dec 15, 2022
@dilverse dilverse deleted the helm_probe_configuration branch December 15, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuration of probes for created containers in Helm chart
3 participants