Support kubectl proxy for Openshift
#1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce offerings installs the Operator in a different Namespace than 'minio-operator" and the token secret name is console-sa-token-{random id}.
Example:
```
kubectl-minio proxy -n openshift-operators
```
`kubectl proxy --help` now shows the `namespace` option help too.
pjuarezd
changed the title
kubectl proxy for Openshiftkubectl proxy for Openshift
pjuarezd
requested review from
dvaldivia,
allanrogerr,
cniackz,
dilverse,
donatello and
shtripat
dvaldivia
approved these changes
Feb 3, 2023
dvaldivia
reviewed
Feb 3, 2023
| secretName := "console-sa-secret" | ||
| if len(sa.Secrets) > 0 { | ||
| secretName = sa.Secrets[0].Name | ||
| secretName := "" |
There was a problem hiding this comment.
I suspect this problem is also present on k8s 1.24+
allanrogerr
approved these changes
Feb 3, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Openshift for
kubectl proxycommand since Openshift Markplace offerings installs the Operator in a different Namespace than 'minio-operator' and the token secret name is console-sa-token-{random id}.Example:
kubectl proxy --helpnow shows thenamespaceoption help too.