Removed references to madmin-go v1.7.5 and updated to v2.0.1 #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
harshavardhana,
cniackz,
reivaj05 and
dvaldivia
|
@bexsoft Could you try mod tidy in the kubectl-minio directory? I believe you may have missed a couple of dependencies there |
allanrogerr
reviewed
Feb 27, 2023
bexsoft
force-pushed
the
updated-madmin-go
branch
from
17331eb
to
55853f9
Compare
cniackz
force-pushed
the
updated-madmin-go
branch
from
342e0ce
to
cf17c9d
Compare
cniackz
force-pushed
the
updated-madmin-go
branch
from
cf17c9d
to
17ffea0
Compare
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
bexsoft
force-pushed
the
updated-madmin-go
branch
from
17ffea0
to
847c8a4
Compare
pjuarezd
approved these changes
Feb 27, 2023
allanrogerr
approved these changes
Feb 28, 2023
| @@ -46,7 +46,7 @@ import ( | |||
| "k8s.io/klog/v2" | |||
|
|
|||
| "github.com/golang-jwt/jwt" | |||
| "github.com/minio/madmin-go" | |||
| "github.com/minio/madmin-go/v2" | |||
There was a problem hiding this comment.
Check failure on line 49 in pkg/apis/minio.min.io/v2/helper.go
GitHub Actions
/ Shellcheck
missing go.sum entry needed to verify package github.com/minio/madmin-go/v2 (imported by github.com/minio/operator/pkg/apis/minio.min.io/v2) is provided by exactly one module; to add:
Check failure on line 49 in pkg/apis/minio.min.io/v2/helper.go
GitHub Actions
/ Analysis (1.19)
missing go.sum entry needed to verify package github.com/minio/madmin-go/v2 (imported by github.com/minio/operator/pkg/apis/minio.min.io/v2) is provided by exactly one module; to add:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Removes references to madmin.go v1.7.5 in favor of v2.0.1.
This PR is related to an issue in console where a dependency is not met
Please refer to minio/console#2682