-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs on TLS for Operator trusting other CAs #1473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
dvaldivia
requested review from
pjuarezd,
cniackz,
reivaj05,
allanrogerr,
bexsoft and
dilverse
February 28, 2023 20:18
pjuarezd
reviewed
Feb 28, 2023
Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com>
pjuarezd
approved these changes
Feb 28, 2023
reivaj05
approved these changes
Feb 28, 2023
allanrogerr
reviewed
Feb 28, 2023
name: my-custom-tls | ||
``` | ||
|
||
and for the `.spec.temaplte.spec.container[0]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
and for the `.spec.temaplte.spec.container[0]` | |
and for the `.spec.template.spec.container[0]` |
kubectl create secret generic my-custom-tls -n minio-operator --from-file=path/to/public.crt | ||
``` | ||
|
||
then add the following volume to the `minio-operator` deployment under .spec.template.spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
then add the following volume to the `minio-operator` deployment under .spec.template.spec | |
Then add the following volume to the `minio-operator` deployment under .spec.template.spec. |
pjuarezd
added a commit
to pjuarezd/operator
that referenced
this pull request
Mar 2, 2023
* Docs on TLS for Operator trusting other CAs Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> * Update docs/operator-tls.md Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com> --------- Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.