Tenant Report Download UI #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
pjuarezd,
cniackz,
reivaj05,
allanrogerr,
dvaldivia,
bexsoft and
dilverse
dvaldivia
requested changes
Mar 13, 2023
|
Tested. LGTM. After addressing the comments we can merge. |
allanrogerr
previously requested changes
Mar 14, 2023
There was a problem hiding this comment.
@jinapurapu API tests failing and therefore also Coverage tests are not getting triggered because of this. Please check.
I understand this is an operator only change and does not affect console.
|
Tests seem to need to change to reflect this change. Im seeing this in checks. It seems to be related: |
jinapurapu
force-pushed
the
tenant_report_download
branch
from
d2fcb84
to
1070f5d
Compare
added 6 commits
March 16, 2023 12:47
Added tests Gofumpt Changes to image to use jill/operator:test Working generateTenantLogReport Cleanup UI changes Fixes
jinapurapu
force-pushed
the
tenant_report_download
branch
from
1070f5d
to
1921c87
Compare
added 3 commits
March 16, 2023 13:52
allanrogerr
approved these changes
Mar 17, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do:
Adds a button on Pods Summary screen of Operator Console, which when clicked requests the server generate the Tenant Log Report, and if successfully generated, downloads the report.
closes https://github.com/miniohq/engineering/issues/1126