Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix release command #1519

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix release command #1519

merged 1 commit into from
Mar 21, 2023

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Mar 21, 2023 •
edited

After the latest changes VERSION=1.2.3 make release command was not working, fixing it:

  • Removed the search for console image, we no longer ship Operator console as an independent image, Operator console is now part of operator binary
  • Now Updating the KES image version when creating an Operator release
  • Removed references in adocs for prometheus, logsearch and postgres docker images.

Once this PR + #1511 are merged will contine with fix olm.sh to generate Openshift releases as well.

@pjuarezd pjuarezd self-assigned this Mar 21, 2023
@pjuarezd
Fix release.sh commmand
3e0c744 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
cniackz
cniackz approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at some point I think we should use latest KES and update the config accordingly, but for now this is ok!. Thank you Pedro.

@pjuarezd pjuarezd merged commit 0918f8e into minio:master Mar 21, 2023
@pjuarezd pjuarezd deleted the fix-release-command branch March 21, 2023 17:59
@dvaldivia
Copy link
Collaborator

LGTM, at some point I think we should use latest KES and update the config accordingly, but for now this is ok!. Thank you Pedro.

we need to add that to the release script @cniackz @pjuarezd

@pjuarezd
Copy link
Member Author

LGTM, at some point I think we should use latest KES and update the config accordingly, but for now this is ok!. Thank you Pedro.

we need to add that to the release script @cniackz @pjuarezd

I just did, in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cniackz cniackz cniackz approved these changes

@dilverse dilverse dilverse approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@balamurugana balamurugana Awaiting requested review from balamurugana

@reivaj05 reivaj05 Awaiting requested review from reivaj05

Assignees

@pjuarezd pjuarezd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pjuarezd @dvaldivia @cniackz @dilverse