Fix describe api to include correct container index #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
force-pushed
the
fix-containers-tab-for-tenant
branch
from
f87edd8
to
183df0b
Compare
dvaldivia
requested review from
pjuarezd,
cniackz,
reivaj05,
allanrogerr,
prakashsvmx and
dilverse
Describe api was returning always the information of the first container.
cesnietor
force-pushed
the
fix-containers-tab-for-tenant
branch
from
e093fb8
to
d4a2727
Compare
cesnietor
changed the title
bexsoft
approved these changes
Apr 25, 2023
dvaldivia
approved these changes
Apr 25, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe api was returning always the information of the first container.
It also updates the previous change done in #1583 so that we clean the response from null values before storing it in the state.
Should still be showing Containers info like:
Response now comes correctly without null objects in Container EnvVariables:
Before:
After:
Test Steps
Similar to : #1583