-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenant chart: : add extra resources capability #1643
Conversation
This commit introduces an extraResources value which is directly rendered as part of the chart like a regular Helm template. This allows users to add some Kubernetes object they might need as part of their cluster configuration. I added in the comment an example of my use case because I use a different type of ingress and it is easier to configure it this way. Closes: minio#1642
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a solution to a certain need. It does not fall into any of the following categories:
- bugfix
- enhancements
- feature
- cleanup
what does this really do? @IxDay |
This allows to ship additional resources with your Helm chart deployment. For instance, I need to deploy an external secret and a different ingress type alongside the minio regular resources. This is dependent on my current config and I think the goal of the Helm chart is not to support every CRD or custom configuration. extraResources:
- |
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
name: {{ dig "secrets" "name" "" (.Values | merge (dict)) }}
spec:
secretStoreRef:
name: {{ dig "secrets" "name" "" (.Values | merge (dict)) }}
kind: SecretStore
refreshInterval: "0"
target:
creationPolicy: Merge
deletionPolicy: Retain
template:
data:
config.env: |-
export MINIO_ROOT_USER='{{ printf "{{.user}}" }}'
export MINIO_ROOT_PASSWORD='{{ printf "{{.password}}" }}'
dataFrom:
- extract:
key: secret/minio/{{.Values.tenant.serviceAccountName}}/creds
conversionStrategy: Default
decodingStrategy: Auto And it will deploy the additional resource using the same helpers and values from the Helm chart |
This commit introduces an extraResources value which is directly rendered as part of the chart like a regular Helm template. This allows users to add some Kubernetes object they might need as part of their cluster configuration.
I added in the comment an example of my use case because I use a different type of ingress and it is easier to configure it this way.
Closes: #1642