Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:hang for serverUpdate failed #1659

Merged
merged 9 commits into from
Jun 27, 2023
Merged

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Jun 26, 2023

fix: hang for serverUpdate failed
related #1645

@jiuker jiuker requested a review from shtripat June 26, 2023 06:17
guozhi.li added 2 commits June 26, 2023 14:17
pkg/controller/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/main-controller.go Outdated Show resolved Hide resolved
jiuker and others added 3 commits June 26, 2023 16:01
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
harshavardhana
harshavardhana previously approved these changes Jun 26, 2023
shtripat
shtripat previously approved these changes Jun 26, 2023
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/controller/main-controller.go Show resolved Hide resolved
@pjuarezd
Copy link
Member

checks had 20 hours running, I've restarted the tests, let's see if was a one-off fail, or somenthing to look at.

@jiuker jiuker dismissed stale reviews from shtripat and harshavardhana via 6bc6882 June 27, 2023 06:13
@pjuarezd pjuarezd merged commit 5b71f04 into minio:master Jun 27, 2023
23 of 24 checks passed
@jiuker jiuker linked an issue Jun 27, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error syncing tenant after tenant image changes
4 participants