New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: containers should be omitempty like the Optional #1817

Merged

harshavardhana merged 1 commit into minio:master from jiuker:fix_type_check_error

Oct 16, 2023

Contributor

jiuker commented Oct 16, 2023

When someone use sidecar's resource to initcontainers's resource.
There is a error output:

Tenant.minio.min.io \"mytenant\" is invalid: spec.sideCars.containers: Required value

This pr will allow the containers can be Optional


          fix: containers should be omitempty like the Optional

9b5bd47

jiuker requested review from shtripat, dvaldivia and harshavardhana

October 16, 2023 03:47

harshavardhana approved these changes

View reviewed changes

shtripat approved these changes

View reviewed changes

Contributor

shtripat left a comment

lgtm

harshavardhana merged commit d4c1641 into minio:master

24 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment