Adding cert-manager test #1844
Merged
Adding cert-manager test #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
force-pushed
the
test-cert-manager-1
branch
6 times, most recently
from
b1481cc
to
4e01b5c
Compare
cniackz
requested review from
pjuarezd,
dvaldivia,
cesnietor,
jiuker,
harshavardhana,
ravindk89,
feorlen and
shtripat
cesnietor
reviewed
Nov 1, 2023
cesnietor
reviewed
Nov 1, 2023
cniackz
force-pushed
the
test-cert-manager-1
branch
from
4e01b5c
to
de53e61
Compare
cniackz
force-pushed
the
test-cert-manager-1
branch
from
de53e61
to
7488e1d
Compare
|
Much appreciate the wiki page with manual test instructions 👍🏻 |
cesnietor
approved these changes
Nov 1, 2023
jiuker
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To add
cert-managertestExplanation:
We have encountered issues with the
cert-managerexample provided in our repository, and we should include a test to ensure it is working correctly before merging any pull requests into the repository.How to manually test:
https://github.com/minio/operator/wiki/cert%E2%80%90manager
Related issue:
Test result: