feat: add env for default operator image #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuker
requested review from
dvaldivia,
harshavardhana,
pjuarezd and
shtripat
|
Can you add the env variable to the list in https://github.com/minio/operator/blob/master/docs/env-variables.md please? @jiuker |
|
@pjuarezd ^^ |
pjuarezd
previously approved these changes
Nov 14, 2023
jiuker
force-pushed
the
add_default_image_env
branch
from
a6937f5
to
0ed01f3
Compare
pjuarezd
previously approved these changes
Nov 14, 2023
harshavardhana
previously approved these changes
Nov 14, 2023
|
@jiuker PTAL at the conflicts |
harshavardhana
approved these changes
Nov 14, 2023
pjuarezd
approved these changes
Nov 14, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add env for default operator image
When operator can't get deployment at first time.
There is no way to set default image for current.
We add a env to set this.