Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pointer from Users field #1892

Merged
merged 1 commit into from
Nov 28, 2023
Merged

remove pointer from Users field #1892

merged 1 commit into from
Nov 28, 2023

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Nov 28, 2023 •
edited

This fixes the problem when invoking /k8s/update-codegen.sh code generator.

 make binary
# github.com/minio/operator/pkg/client/applyconfiguration/minio.min.io/v2
pkg/client/applyconfiguration/minio.min.io/v2/tenantspec.go:309:29: cannot use *values[i] (variable of type "k8s.io/api/core/v1".LocalObjectReference) as *"k8s.io/api/core/v1".LocalObjectReference value in argument to append
make: *** [binary] Error 1

@pjuarezd
remove pointer from Users field
1c3fa37 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd self-assigned this Nov 28, 2023
@pjuarezd pjuarezd merged commit eaf5f0c into minio:master Nov 28, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivaj05 reivaj05 reivaj05 approved these changes

@bexsoft bexsoft bexsoft approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@cniackz cniackz Awaiting requested review from cniackz

@cesnietor cesnietor Awaiting requested review from cesnietor

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

Assignees

@pjuarezd pjuarezd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pjuarezd @reivaj05 @bexsoft