Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add annotations to operator #1914

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Dec 18, 2023

feat: add annotations to operator

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified.

$ kubectl get deployments/minio-operator -n minio-operator -oyaml | yq '.metadata.annotations' 
deployment.kubernetes.io/revision: "1"
kubectl.kubernetes.io/last-applied-configuration: |
  {"apiVersion":"apps/v1","kind":"Deployment","metadata":{"annotations":{"operator.min.io/authors":"MinIO, Inc.","operator.min.io/license":"AGPLv3","operator.min.io/support":"https://subnet.min.io"},"labels":{"app.kubernetes.io/instance":"minio-operator","app.kubernetes.io/name":"operator"},"name":"minio-operator","namespace":"minio-operator"},"spec":{"replicas":2,"selector":{"matchLabels":{"name":"minio-operator"}},"strategy":{"type":"Recreate"},"template":{"metadata":{"annotations":{"operator.min.io/authors":"MinIO, Inc.","operator.min.io/license":"AGPLv3","operator.min.io/support":"https://subnet.min.io"},"labels":{"app.kubernetes.io/instance":"minio-operator","app.kubernetes.io/name":"operator","name":"minio-operator"}},"spec":{"affinity":{"podAntiAffinity":{"requiredDuringSchedulingIgnoredDuringExecution":[{"labelSelector":{"matchExpressions":[{"key":"name","operator":"In","values":["minio-operator"]}]},"topologyKey":"kubernetes.io/hostname"}]}},"containers":[{"args":["controller"],"env":[{"name":"MINIO_CONSOLE_TLS_ENABLE","value":"off"},{"name":"OPERATOR_STS_ENABLED","value":"on"}],"image":"docker.io/minio/operator:annon","imagePullPolicy":"IfNotPresent","name":"minio-operator","resources":{"requests":{"cpu":"200m","ephemeral-storage":"500Mi","memory":"256Mi"}},"securityContext":{"runAsGroup":1000,"runAsNonRoot":true,"runAsUser":1000}}],"serviceAccountName":"minio-operator"}}}}
min.io/operator: annon <<===========
operator.min.io/authors: MinIO, Inc.
operator.min.io/license: AGPLv3
operator.min.io/support: https://subnet.min.io

@pjuarezd pjuarezd merged commit bb43a3e into minio:master Dec 18, 2023
25 checks passed
dvaldivia added a commit that referenced this pull request Feb 27, 2024
dvaldivia added a commit that referenced this pull request Feb 27, 2024
Revert "feat: add annotations to operator (#1914)"

This reverts commit bb43a3e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants