Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using kustomize rather than krew plugin for the readme #1947

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Jan 23, 2024

Objective:

To use Kustomization rather than Krew Plugin for the README.md

To fix: #1818

Reasoning:

We believe kustomization is preferred over krew plugin for the k8s deployment of Operator and MinIO. Plugin is not being delted, just moved to a different file.

ravindk89
ravindk89 previously approved these changes Jan 23, 2024
Copy link
Contributor

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit to guide users to installing kustomize.

We can also cover this in webdocs if we want to show both pathways side-by-side.

README.md Show resolved Hide resolved
Co-authored-by: Ravind Kumar <ravindk89@gmail.com>
@pjuarezd pjuarezd merged commit 99d7e4c into minio:master Feb 6, 2024
25 checks passed
feorlen added a commit to minio/docs that referenced this pull request May 9, 2024
New page with Kustomize Operator deployment instructions, as a sibling
to the existing Helm page. Includes some matching updates to the Helm
page, for consistency.

Replacing the Krew instructions (numerous locations) will be a separate
PR.

Staged

http://192.241.195.202:9000/staging/DOCS-1125/k8s/operations/install-deploy-manage/deploy-operator-kustomize.html

See also: minio/operator#1947

Fixes #1125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md should include instructions for deploying with pure kustomize (no krew)
3 participants