Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nearest zero-based pool name for expansion #1950

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

allanrogerr
Copy link
Contributor

Issue summary

After tenant expansion and decommission, further expansion is not always possible using the MinIO tenant console.

As an example, in a deployment with pool-0 and pool-1, after pool-0 decommission, a subsequent expansion by the console tries and fails to create pool-1 which already exists.

This is because the MinIO tenant console automatically names pools based on the number of pools in existence. If there is 1 pool, then the logic will try to create pool-1 - which may be incorrect as shown above. This logic needs to consider examining the pools already in existence before determining which pool name to use.

Test summary

Reproduce issue on master
Test 0 - As reported by user, Create using Console, Expand using Console, Decommission pool-0, Expand tenant using Console

Fix on improve-poolname-search branch
Test 1 - Create tenant using console, Expand using kubectl-minio, Decommission pool-0, Expand tenant using Console
Test 2 - Create tenant using kubectl-minio, Expand using console, Decommission 0pool, Expand tenant using Console
Test 3 - As reported by user, Create tenant using Console, Expand tenant using Console, Decommission pool-0, Expand tenant using Console
Test 4 - Create tenant using kubectl, Expand tenant using kubectl, Decommission pool-1, Expand tenant using Console

Verbose tests here:
https://github.com/allanrogerr/public/wiki/operator%E2%80%901785

Fixes: #1785

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@allanrogerr allanrogerr merged commit ea9299f into minio:master Jan 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't expand a tenant. Pool exists.
4 participants